RegistryClassInfo Housekeeping#8759
Open
APickledWalrus wants to merge 1 commit into
Open
Conversation
APickledWalrus
requested review from
UnderscoreTud and
cheeezburga
and removed request for
a team
Absolutionism
approved these changes
Jul 7, 2026
Absolutionism
left a comment
Absolutionism
left a comment
Contributor
There was a problem hiding this comment.
Want to go ahead and remove the 1.21.4 environment + workflow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This PR addresses a few problems:
Solution
I've removed the need for the defaultExpression constructor parameter by allowing
defaultExpressionto be used more than once on ClassInfo. Until we have a sane builder system, I think this will be fine.I've deprecated the existing
Registrybased constructors in favor of others usingRegistryKey. It is useful to store RegistryKey as well for future work (e.g. command arguments). For now, for compatibility, it is nullable. I don't believe there is a way to go from Registry->RegistryKey (someone please correct me if I am wrong).Finally, I've overridden some of the ClassInfo methods to guarantee stronger contracts.
I've also updated all deprecated usages and cleaned up the unnecessary EntityData work.
Testing Completed
Standard tests to confirm continued functionality.
Supporting Information
This PR will not run on the 1.21.4 environment. I've updated the API version to 1.21.5 for the purposes of the other versions (below 1.21.5, the bytecode rewriter will rewrite Cow into AbstractCow, cause NSME for variant operations). This should be done separately in a proper PR after 2.16 is released.
Completes: none
Related: none
AI assistance: none